Fix Epeck_d spatial searching compilation - #9570
Open
UtkarsHMer05 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Spatial Searching compilation failures when using
Epeck_d.Iterator_from_indicesalready implements the operations required by arandom-access iterator through
increment(),decrement(),advance(),and
distance_to(), but advertised only bidirectional traversal.This change:
operator[]returning the iterator reference type,avoiding the inherited Boost proxy result;
Epeck_d;Fuzzy_iso_box,Fuzzy_sphere, Kd-tree insertion, search,removal, and size verification.
The regression test is enabled when Eigen support is available.
Fixes #9534.
Validation
Validated from a clean worktree based on
public/maincommit10968626f93fca92bd0b2b934c2899819e732bb1.expected iterator/random-access compilation errors.
Epick_d,Epick_d_eigen,test_bbox_d,remove, andSplitterstests.tri2Debug test with 1,000 points.